test: fix parameter order passed to strictEqual #23577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.:
addaleax
added
the
code-and-learn
addaleax
approved these changes
Oct 12, 2018
digitalinfinity
approved these changes
Oct 12, 2018
jasnell
approved these changes
Oct 12, 2018
BridgeAR
approved these changes
Oct 12, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/17777/ |
cjihrig
approved these changes
Oct 12, 2018
addaleax
approved these changes
Oct 12, 2018
|
Collaborators, please 👍 here to fast-track. |
gireeshpunathil
approved these changes
Oct 13, 2018
|
👍 for fast-tracking left-to-right: @joyeecheung, @targos, @addaleax, @Trott:
|
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 13, 2018
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.: PR-URL: nodejs#23577 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
Landed in c1288fe |
addaleax
pushed a commit
that referenced
this pull request
Oct 14, 2018
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.: PR-URL: #23577 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.: PR-URL: #23577 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.: PR-URL: #23577 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.: PR-URL: #23577 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
strictEqual() expects the first argument to be the actual value and the second argument to be the expected value. This fix will correctly label the AssertionError.: PR-URL: #23577 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strictEqual() expects the first argument to be the actual value and the
second argument to be the expected value. This fix will correctly label
the AssertionError.:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes